Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for Google Compute Engine App #1432

Merged
merged 3 commits into from
Jul 14, 2016
Merged

Documentation update for Google Compute Engine App #1432

merged 3 commits into from
Jul 14, 2016

Conversation

Gormartsen
Copy link
Contributor

This changes fix next error:

  operation.onComplete(function(err, metadata) {
            ^

TypeError: operation.onComplete is not a function

Tested.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2016
@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 496cd73 on Zen-CI:master into 14d5cb0 on GoogleCloudPlatform:master.

@@ -391,7 +391,7 @@ var name = 'ubuntu-http';
zone.createVM(name, { os: 'ubuntu' }, function(err, vm, operation) {
// `operation` lets you check the status of long-running tasks.

operation.onComplete(function(err, metadata) {
operation.on("complete", function(err, metadata) {

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor

Phew, good catch. Thank you!

@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 74d1233 on Zen-CI:master into 14d5cb0 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 976cb69 into googleapis:master Jul 14, 2016
@stephenplusplus
Copy link
Contributor

Woo! Thank you for not just getting frustrated and moving on. Fellow developers who would have been confused have you to thank. Have a good night!

@stephenplusplus stephenplusplus added docs api: compute Issues related to the Compute Engine API. labels Jul 14, 2016
@Gormartsen
Copy link
Contributor Author

@stephenplusplus 👍 same to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants